Non-empty stack traces for operator exceptions. #1324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #1235 by ensuring there's a
StackTrace
for operators such asSingleAsync
when propagating onOnError
exception they've created themselves. Because there's no stack to unwind (observer.OnError
goes "the other way"), the exception info is limited to the current frame (e.g.OnCompleted
inSingleAsync
noticing there was no element and thus propagating anInvalidOperationException
). At the very least, it gives a clue about the operator that caused it. Further root cause analysis remains a debugging task (e.g. why the sequence produced no elements) but this can help to steer investigations.